Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby crashes under Haiku #1109

Closed
wants to merge 5 commits into from
Closed

Fix ruby crashes under Haiku #1109

wants to merge 5 commits into from

Conversation

kallisti5
Copy link

Ruby tests now run successfully under Haiku without fault / crash

PASS all 1010 tests

@nobu
Copy link
Member

nobu commented Nov 22, 2015

Thank you, seems great.

A few questions:

  • from what version of Haiku do these patches work?
  • do older versions work without these patches?
  • are older versions obsolete already?

@kallisti5
Copy link
Author

  • from what version of Haiku do these patches work?
    Latest nightly os images.
  • Do older versions work without these patches?
    Ruby ran without these patches, however had multiple crashes as it couldn't find the end of the stack.
  • are older versions obsolete already?
    Haiku's previous Alpha release (4) is pretty outdated and not generally used in the community. We really need a new release. Alpha 4 didn't even include all of our new package management.

The nice part of these patches is we're removing a lot of ifdef __HAIKU__ statements making the code more maintainable with less upkeep from the ruby devs.

@nobu
Copy link
Member

nobu commented Nov 23, 2015

OK, then could you mention it at the end of the NEWS file, “Implementation changes” section?

@kallisti5
Copy link
Author

done. I used the words "best effort" for now.

@nobu nobu closed this in e29c109 Nov 23, 2015
mrkn pushed a commit to mrkn/ruby that referenced this pull request Apr 17, 2016
* configure.in: remove obsolete workarounds for Haiku.
* dln.c, file.c, io.c: remove obsolete Haiku workarounds.
* thread_pthread.c: add stack bounds detection for Haiku.
* signal.c: get stack pointer from signal context on Haiku.
  [ruby-core:67923] [Bug ruby#10811] [Fix rubyGH-1109]

git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@52721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants