Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up REXML-3.3.2 #11172

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Bump up REXML-3.3.2 #11172

merged 2 commits into from
Jul 16, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jul 16, 2024

@hsbt hsbt added the Backport label Jul 16, 2024
@hsbt
Copy link
Member Author

hsbt commented Jul 16, 2024

@kou @Watson1978 The following test of REXML-3.3.2 is failing with Ruby 3.1.x.

Failure: test_linear_performance_attribute_value_gt(REXMLTests::TestParseElement):
    [150000]: in 0.015s.
    <0.04155644600001551> was expected to be
    <=
    <0.015>.

Do you have an idea to fix that?

@kou
Copy link
Member

kou commented Jul 16, 2024

Hmm. It's not happen on ruby/rexml: https://github.com/ruby/rexml/actions/runs/9949888216/job/27486869388

I re-run these jobs on this PR for now.
We may need to relax the expected range.

@hsbt
Copy link
Member Author

hsbt commented Jul 16, 2024

Thanks, I also re-run another failure: https://github.com/ruby/ruby/actions/runs/9950962925/job/27500262330?pr=11172

@hsbt hsbt merged commit 97c3ed7 into ruby:ruby_3_1 Jul 16, 2024
74 checks passed
@hsbt hsbt deleted the rexml-3-3-2-ruby-3-1 branch July 16, 2024 10:02
@hsbt
Copy link
Member Author

hsbt commented Jul 16, 2024

@kou I merged REXML-3.3.2 for Ruby 3.1.x. I will suggest to relax this condition if I encounter same failure in the next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants