Reword ArgumentError message #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentError: wrong number of arguments (%d instead of %d). It clarifies the message.
|
Agreed. Might break some tests tho? |
|
Do you mean tests that assert the message? Yes, those would be broken. But it would be an easy – search and replace – fix. |
|
Due to the backwards incompatible nature of this patch, I think it would be best top request a new feature in redmine. @Nerian Could you move this to a feature request on http://bugs.ruby-lang.org/ and update/close this ticket when done? Within a few days/weeks I can do this for you. Thanks! |
|
Sure thing. There it is: http://bugs.ruby-lang.org/issues/9025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 'ArgumentError: wrong number of arguments (%d for %d)' to ArgumentError: wrong number of arguments (%d instead of %d).
This clarifies the meaning of the message without any room for doubt.
And looks like raises many doubts: http://stackoverflow.com/questions/7537450/what-does-wrong-number-of-arguments-1-for-0-mean-in-ruby
Personally, I did find the wording weird the first time I saw that error message and I had to google it to make sure I got it right. With this pull request, we leave no room for further doubt.