xwillfree - promise to free memory #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes semantic of RUBY_GC_MALLOC_LIMIT. Instead of being "periodical trigger" it becomes more like "safety trigger" which fires in allocation increase (instead of allocation amount). So that there is less need to tune RUBY_GC_MALLOC_LIMIT at all, and default 8Mb becomes meaningful. Before GC relaxation in commit 8c0033a `make check` ran 13% faster (292s instead of 338s) and doesn't seems to use more memory. It is now runs at the same speed, but I propose to revert some part of GC relaxation (in a next commit). Tradeoffs for patch simplicity: - it is not exact: only String, Array, Object, Struct, Bignum and Time are handled - only one function (xwillfree) introduced. Perhaps, more readable api could be useful. - xwillfree exposed to the public (ruby.h). Perhaps, it should be in an internal.h, but st.c doesn't include internal.h . But may be it could be useful for extensions.
they are not such useful if xwillfree accepted
|
This issue is solved by https://bugs.ruby-lang.org/issues/8985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes semantic of RUBY_GC_MALLOC_LIMIT.
Instead of being "periodical trigger" it becomes more like "safety trigger"
which fires in allocation increase (instead of allocation amount).
So that there is less need to tune RUBY_GC_MALLOC_LIMIT at all, and default
8Mb becomes meaningful.
Before GC relaxation in commit 8c0033a
make checkran 13% faster(292s instead of 338s) and doesn't seems to use more memory. It is now
runs at the same speed, but I propose to revert some part of GC
relaxation (in a second commit).
Tradeoffs for patch simplicity:
handled
could be useful.
internal.h, but st.c doesn't include internal.h .
But may be it could be useful for extensions.
Issue http://bugs.ruby-lang.org/issues/8985