strio_read: preserve buffer encoding on partial reads #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Bug #20418] Ruby IO#read preserves the encoding on partial read, but change it when reading the whole IO from commit 0ca7036682dad1caea4e7a4fe8fd908d94c878e8: > * io.c (read_all): should associate default external encoding. > * io.c (io_read): should NOT associate default external encoding.
nobu
approved these changes
Apr 15, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 17, 2024
reads (ruby/stringio#95) [[Bug #20418]](https://bugs.ruby-lang.org/issues/20418) Ruby IO#read preserves the encoding on partial read, but change it when reading the whole IO from commit 0ca7036682da: > * io.c (read_all): should associate default external encoding. > * io.c (io_read): should NOT associate default external encoding. ruby/stringio@073172da31 Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
reads (ruby/stringio#95) [[Bug #20418]](https://bugs.ruby-lang.org/issues/20418) Ruby IO#read preserves the encoding on partial read, but change it when reading the whole IO from commit ruby@0ca7036682da: > * io.c (read_all): should associate default external encoding. > * io.c (io_read): should NOT associate default external encoding. ruby/stringio@073172da31 Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug #20418]
Ruby IO#read preserves the encoding on partial read, but change it when reading the whole IO
from commit ruby/ruby@0ca7036:
cc @nobu