Skip to content

Translate latest news posts (ko) #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2015

Conversation

wagurano
Copy link
Contributor

Hello, rubyists!
Here’s the Korean translation of the 2.3.0-preview1 post. I want to review this PR.
Thank you in advance.

@@ -0,0 +1,80 @@
---
layout: news_post
title: "루비 2.3.0-프리뷰1 릴리스"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version should be the same as the original one: '2.3.0-preview1'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, "preview" is part of the version name and should never be translated.

'preview1' is not translated.
Edit postposition(조사: 은,는,를,으로) and
word spacing(segmentation, 띄어쓰기)
Edit '변동점' to '변경'
marocchino added a commit that referenced this pull request Nov 23, 2015
@marocchino marocchino merged commit cb1f900 into ruby:master Nov 23, 2015
@marocchino
Copy link
Member

Thanks.

@stomar
Copy link
Contributor

stomar commented Nov 23, 2015

Please do not use non-ASCII characters in commit messages, and squash little fixes like that in one commit (it's not necessary to document the translation process, only clobbers the history).

@marocchino
Copy link
Member

@stomar Thanks for feedback. Next time, I will check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants