Skip to content

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Oct 14, 2017

Currently, CI is passed even though test task is failed

@mtsmfm mtsmfm changed the title Exit with non zero when some tests failed Run test on CI Oct 14, 2017
@mtsmfm mtsmfm changed the title Run test on CI Run test on Travis CI Oct 14, 2017
@hsbt hsbt merged commit beb8b32 into ruby:master Oct 15, 2017
@mtsmfm mtsmfm deleted the fix-test branch October 15, 2017 11:11
@stomar
Copy link
Contributor

stomar commented Oct 23, 2017

That was by intention; the test tasks were meant more as a kind of linter, and were run only occasionally (manually) to not slow down CI. But anyway, I don't object to running those always if nobody minds the extra time (not sure how much it is, actually).

@mtsmfm
Copy link
Contributor Author

mtsmfm commented Oct 23, 2017

@stomar

That was by intention

Sorry, I didn't know about that 💦

According to the following snnipet, CI got 40 seconds slower.

[56] pry(main)> Travis::Repository.find('ruby/www.ruby-lang.org').builds.lazy.select(&:green?).select {|b| b.branch_info == 'master' && b.number.to_i < 4287 }.take(10).sum(&:duration) / 10.0
=> 220.2
[57] pry(main)> Travis::Repository.find('ruby/www.ruby-lang.org').builds.lazy.select(&:green?).select {|b| b.branch_info == 'master' && b.number.to_i >= 4287 }.take(10).sum(&:duration) / 10.0
=> 260.3

I hope you all accept this extra time to find easy mistakes such like:

964d1eb#diff-5d067bc5dd97efa0e642d38b7bb88d0f

@stomar
Copy link
Contributor

stomar commented Oct 23, 2017

Yes, considering those kind of mistakes happen from time to time, I now tend to think it's a good idea to run those tests. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants