Skip to content

Remove no longer existing blastwave.org #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

VagishVela
Copy link
Contributor

The website doesn't exist anymore.

I've removed all occurrences of it apart from in the Japanese text where it was hard to identify where the sentence starts and ends.

@yous
Copy link
Member

yous commented Oct 19, 2018

It seems that vi also needs an review.

The website doesn't exist anymore.
@VagishVela VagishVela force-pushed the remove-broken-blastwave-urls branch from 1d86aec to d83e85a Compare October 19, 2018 09:33
@VagishVela
Copy link
Contributor Author

@yous @JuanitoFatas I've updated and squashed the commits.

Not sure I can help with vi, do you know who can?

@@ -142,7 +142,7 @@ Lệnh trên sẽ cài đặt phiên bản mới nhất của Ruby.

Ruby 1.8.7 có sẵn từ Solaris 8 đến Solaris 10 trên
[Sunfreeware][sunfreeware] và Ruby 1.8.7 có sẵn ở
[Blastwave][blastwave].
Blastwave.
Copy link
Member

@JuanitoFatas JuanitoFatas Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JONESLEE85 know anyone could help review this? Thanks!

@stomar
Copy link
Contributor

stomar commented Oct 19, 2018

It‘s problematic to underake changes like this without knowledge of the language; e.g. for the de version the language is wrong now.

I would suggest:

  • fix the en version
  • then, only fix the translations where you have sufficient language knowledge
  • leave the others unchanged: it‘s better to have an obviously outdated version that will eventually be fixed by the translation teams than to make seem that all is fixed and introduce errors that will never be noticed

And another thing regarding the Solaris section: does someone know whether the other information in this section is still valid at all? (It obviously is very outdated.)

@stomar stomar closed this in b0fc2a7 Mar 8, 2019
@stomar
Copy link
Contributor

stomar commented Mar 8, 2019

I only removed the links, leaving the text unchanged. Since the Solaris paragraph has been removed, the translators need to update the section, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants