Skip to content

Paralleling Travis jobs to shorten build duration #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

alaxalves
Copy link
Contributor

@alaxalves alaxalves commented Mar 6, 2019

Fixed the in-between travis build caching problem and makes the jobs parallel making easier to identify an eventual issue.

@alaxalves alaxalves requested a review from a team as a code owner March 6, 2019 01:30
@stomar
Copy link
Contributor

stomar commented Mar 8, 2019

Could you please shortly explain the „in-between travis build caching problem“?

@alaxalves
Copy link
Contributor Author

Could you please shortly explain the „in-between travis build caching problem“?

When you add caching like this:

cache:
  bundler: true

to Travis you must specify a directory to cache as specified here. This was causing Travis not cache properly sometimes. Since ruby-lang does not specify a different folder to install dependencies just using cache: bundler to the yml fixes it.

@stomar
Copy link
Contributor

stomar commented Mar 8, 2019

I added a commit with a simpler config: matrix is not necessary here (no global env vars), and using TASK instead of SCRIPT makes the log more readable, IMO.

What do you think?

@alaxalves
Copy link
Contributor Author

@stomar I think it's great. Thank you for the feedback.

Copy link
Contributor

@stomar stomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. @hsbt

@hsbt hsbt merged commit d229628 into ruby:master Mar 11, 2019
@alaxalves alaxalves deleted the travis-improv branch March 11, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants