Fix: Improve Korean translation quality #3526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjy-par
force-pushed
the
fix-ko-awkward-translations
branch
from
4797477 to
7535c15
Compare
yous
reviewed
Mar 15, 2025
kimjy-par
force-pushed
the
fix-ko-awkward-translations
branch
from
7535c15 to
4a4ef07
Compare
yous
approved these changes
Mar 15, 2025
marocchino
reviewed
Mar 15, 2025
| @@ -64,7 +64,7 @@ end | |||
| 매개 변수입니다. | |||
|
|
|||
| 여기서 일어나고 있는 것은 리스트의 각 원소가 `name` 변수에 넘겨져서, 그 `name`을 | |||
| 가지고 `puts “Hello#\{name}!”` 코드가 실행되고 있는 거랍니다. | |||
| 가지고 `puts “Hello #{name}!”` 코드가 실행되고 있는 거랍니다. | |||
There was a problem hiding this comment.
Suggested change
| 가지고 `puts “Hello #{name}!”` 코드가 실행되고 있는 거랍니다. | |
| 가지고 `puts "Hello #{name}!"` 코드가 실행되고 있는 거랍니다. |
There was a problem hiding this comment.
Thank you for the valuable suggestion. I've made the modifications as you recommended.
marocchino
reviewed
Mar 15, 2025
| @@ -65,7 +65,7 @@ Hello Matz! | |||
|
|
|||
| ## 문자열의 중간에 자리를 잡아두기 | |||
|
|
|||
| `#\{name}` 부분은 무엇이냐구요? Ruby에서 문자열 중간에 무엇을 삽입하는 방법입니다. | |||
There was a problem hiding this comment.
https://github.com/search?q=repo%3Aruby%2Fwww.ruby-lang.org%20%23%5C%7B&type=code
Code quotes seem to have been added later. There are traces of them in other languages as well.
kimjy-par
force-pushed
the
fix-ko-awkward-translations
branch
from
4a4ef07 to
ded4203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Details
This PR focuses on improving the Korean documentation by correcting terminology, removing unexpected characters, and enhancing overall readability.