Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ENV GEM_SPEC #489

Closed
wants to merge 2 commits into from

Conversation

mpapis
Copy link
Contributor

@mpapis mpapis commented Mar 6, 2013

details in #430

@drbrain
Copy link
Member

drbrain commented Mar 6, 2013

Likely the failure is due to travis having ruby 2.0.0dev (2012-12-12) instead of p0, I'm unsure what causes the 1.8.7 failures as it runs fine on my local machine and I haven't cared to investigate.

@mpapis
Copy link
Contributor Author

mpapis commented Mar 6, 2013

looks like missing minitest gem for 1.8.7

@mpapis
Copy link
Contributor Author

mpapis commented Mar 6, 2013

while testing again I found out there are some tests that have the path hard coded and they fail if GEM_SPEC is set in environment ...

@drbrain
Copy link
Member

drbrain commented Mar 6, 2013

It gets installed and required but cannot be loaded.

Something must be clearing the available gem list, but I'm unsure what I need to do to find my bug. Instead of investigating it I dropped it into the allowed failures list.

drbrain added a commit that referenced this pull request Apr 4, 2013
This name better matches the default name (gem_spec_cache_dir) and is a
little clearer than "GEM_SPEC" which has multiple meanings in RubyGems.
@drbrain
Copy link
Member

drbrain commented Apr 4, 2013

I applied your two commits manually and changed the environment variable to GEM_SPEC_CACHE which better matches Gem.gem_spec_cache_dir and is a little less ambiguous as "spec" has multiple meanings in RubyGems.

@drbrain drbrain closed this Apr 4, 2013
@mpapis mpapis deleted the features/ENV_GEM_SPEC branch April 4, 2013 01:11
drbrain added a commit that referenced this pull request Apr 4, 2013
This name better matches the default name (gem_spec_cache_dir) and is a
little clearer than "GEM_SPEC" which has multiple meanings in RubyGems.
drbrain added a commit that referenced this pull request Apr 4, 2013
* pietro-key_passphrase: (154 commits)
  Update missed tests for rebase of #447
  Fixed pull request number type for #461
  Improve documentation of DependencyInstaller
  Alphabetize Gem::DependencyInstaller
  Removed commented out DependencyInstaller code
  Alter #489 to use GEM_SPEC_CACHE
  fix tests when GEM_SPEC is set in environment
  add support for ENV GEM_SPEC, fix #430
  Updated history for #443
  Don't alter Gem::Specification.dirs during install
  Default to Gem.dir as late as possible.
  Updated history for #455
  Update history for #456
  Update history for #462
  Add tests and alter output of #514
  add PATH to gem env
  Update History for #514
  Restore backwards-compatibility for #517
  Alphabetize RequestSet
  Undent RequestSet
  ...

Conflicts:
	test/rubygems/test_gem_commands_cert_command.rb
	test/rubygems/test_gem_package.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants