Skip to content

Retain string encoding when raising exception #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2025
Merged

Retain string encoding when raising exception #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ext/mini_racer_extension/mini_racer_extension.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,8 +1005,8 @@ static void handle_exception(VALUE e)

if (NIL_P(e))
return;
StringValue(e);
s = RSTRING_PTR(e);
e = StringValue(e);
s = StringValueCStr(e);
switch (*s) {
case NO_ERROR:
return;
Expand All @@ -1028,7 +1028,7 @@ static void handle_exception(VALUE e)
default:
rb_raise(internal_error, "bad error class %02x", *s);
}
rb_raise(klass, "%s", s+1);
rb_enc_raise(rb_enc_get(e), klass, "%s", s+1);
}

static VALUE context_alloc(VALUE klass)
Expand Down
11 changes: 11 additions & 0 deletions test/mini_racer_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,4 +1172,15 @@ def test_large_integer
assert_equal(types, %w[number bigint number bigint])
end
end

def test_exception_message_encoding
e = nil
begin
MiniRacer::Context.new.eval("throw Error('ä')")
rescue MiniRacer::RuntimeError => e_
e = e_
end
assert e
assert_equal(e.message.encoding.to_s, "UTF-8")
end
end
Loading