-
-
Notifications
You must be signed in to change notification settings - Fork 221
Updating advisories with osvdb.org in "url:" field #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary url:
should ideally point to a web page with the advisory information, that explains the impact. how to upgrade, etc. It's probably not very user-friendly to link to raw GitHub code or commit diffs. If no other suitable URL exists for the advisory, perhaps we could link to the https://rubysec.com page for the advisory?
I agree that sometimes is was hard to find the right one for the main "url:" field. My approach was to pick the public announcement of the vulnerability by the project if possible or proof that the vulnerability was real. I will review your feedback and try to improve my selection. |
Found 2 more files needing similar changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks |
Updating advisories with osvdb.org in "url:" field
Special Notes
Checks