Skip to content

Conversation

jasnow
Copy link
Contributor

@jasnow jasnow commented May 31, 2023

Updating advisories with osvdb.org in "url:" field

  • Updated "url:" field with non-osvdb reference since osvdb.org is no longer available.
  • Added "ghsa:" field value for advisories with "cve:" values.
  • Added "related:" references as evidence for further work (for advisories with "cve": values, usually only 4 refs; check NVD reference for full list).
  • Changed quotes to or adding double-quotes as needed.
  • Added "notes:" as needed to be more explicit.
  • Line wrapped text fields as needed.
  • Merged one duplicate OSVDB-78119 advisory into CVE-2012-5372 advisory.

Special Notes

  • No new files/advisories in this PR.
  • Will delete rubies/rbx/OSVDB-78119.yml file in separate PR.

Checks

  • internal "morechks" script (all clean)
  • yamlint (green)
  • rake (green)

@postmodern postmodern self-requested a review May 31, 2023 23:24
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary url: should ideally point to a web page with the advisory information, that explains the impact. how to upgrade, etc. It's probably not very user-friendly to link to raw GitHub code or commit diffs. If no other suitable URL exists for the advisory, perhaps we could link to the https://rubysec.com page for the advisory?

@jasnow
Copy link
Contributor Author

jasnow commented Jun 2, 2023

The primary url: should ideally point to a web page with the advisory information, that explains the impact. how to upgrade, etc. It's probably not very user-friendly to link to raw GitHub code or commit diffs. If no other suitable URL exists for the advisory, perhaps we could link to the https://rubysec.com page for the advisory?

I agree that sometimes is was hard to find the right one for the main "url:" field. My approach was to pick the public announcement of the vulnerability by the project if possible or proof that the vulnerability was real. I will review your feedback and try to improve my selection.

@jasnow
Copy link
Contributor Author

jasnow commented Jun 2, 2023

Found 2 more files needing similar changes.

@postmodern postmodern self-requested a review June 3, 2023 02:51
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@postmodern postmodern merged commit 77ae7ba into rubysec:master Jun 3, 2023
@jasnow
Copy link
Contributor Author

jasnow commented Jun 3, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants