-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: snowflake appendmode #3745
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3745 +/- ##
==========================================
+ Coverage 68.69% 68.73% +0.03%
==========================================
Files 345 345
Lines 51652 51601 -51
==========================================
- Hits 35484 35468 -16
+ Misses 13881 13846 -35
Partials 2287 2287
☔ View full report in Codecov by Sentry. |
32c8b92
to
9712623
Compare
0322792
to
1a0fc96
Compare
f2cbf42
to
c511406
Compare
logFields := []interface{}{ | ||
lf.SourceID, sf.Warehouse.Source.ID, | ||
lf.SourceType, sf.Warehouse.Source.SourceDefinition.Name, | ||
lf.DestinationID, sf.Warehouse.Destination.ID, | ||
lf.DestinationType, sf.Warehouse.Destination.DestinationDefinition.Name, | ||
lf.WorkspaceID, sf.Warehouse.WorkspaceID, | ||
lf.Namespace, sf.Namespace, | ||
lf.TableName, tableName, | ||
lf.LoadTableStrategy, sf.config.loadTableStrategy, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ It definitely cleaned up a lot of duplicate code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with minor comments
Description
Adding
APPEND
mode for Snowflake.Changelog
MERGE INTO
queryloadTableStrategy
feature flagAPPEND
support toLoadTable
with integration testsAPPEND
support toLoadUserTables
with integration testsLinear Ticket
< Linear Link >
Security