-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: More accurate types in generated rune API documentation #757
Comments
Might be relatively straight forward albeit a bit tedious. You'd have to add the generic wherever they are referenced like here for the return type: rune/crates/rune/src/doc/context.rs Line 41 in 7fd96d2
And populate them from the context. Finally you'd have to pass them into the link function here and modify it to take and recursively build links for generic parameters. I'm thinking it might be appropriate to define a higher level type which captures both the base type and its generic parameters instead of just exposing a bare hash like we do now. Something like this:
And then pass that into the |
After landing #759, what we need to do next is to provide the necessary metadata through the This also affects |
That was amazingly quick! Didn't even have time to start looking into doing it myself. |
Cheers. Yeah, I think with #765 it's pretty much as good as it can be. Thanks for pointing this out! |
Currently when a generic type (e.g.
Option<MyCustomType>
) is part of a function signature in an external function. the rune docs only show the outermost type (e.g.Option
). It would be very useful to be able to see the full type.I'm not sure how hard this would be to add, I would be interested in looking into this if this is a "relatively easy" thing.
The text was updated successfully, but these errors were encountered: