Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix derive macros outside rune #531

Closed
wants to merge 1 commit into from
Closed

Fix derive macros outside rune #531

wants to merge 1 commit into from

Conversation

ModProg
Copy link
Contributor

@ModProg ModProg commented May 27, 2023

fixes #530

@udoprog
Copy link
Collaborator

udoprog commented May 27, 2023

Honestly, not worth the extra complexity (esp. w.r.t. manifest parsing) and dependency: All public macros are re-exported from rune, and all you need to make them work internally is use crate as rune (you can see this in some places).

If one of the public macros do not use rune:: as a default prefix (which I think most of them do), it should be fixed.

@udoprog udoprog closed this May 27, 2023
@udoprog udoprog mentioned this pull request May 27, 2023
Closed
@udoprog udoprog added the wontfix This will not be worked on label May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make derive macros work outside of rune
2 participants
@ModProg @udoprog