Finalize removal of typed pointers #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 8, 2024 16:41
On llvm 15, the llvm::PointerType::getUnqual(llvm::Type *) function still creates typed pointers. We don't want to use typed pointers ata ll, so we remove these call sites and replace them with the getUnqual overload that uses opaque pointers. Some further refactoring to condense and clean up the code is probably a good idea in the future; this makes a lot of the code kind of weird because I did a purely mechanical translation rather than attempting to make the code look the way it would if we had written it for the first time with opaque pointers.
On llvm 15, CreateMalloc seems to be broken in some cases when working with opaque pointers. This is probably due to an llvm bug. However, this function has a lot of complexity when really it's doing something pretty simple. So I have replaced the complex version of the code with a fairly simple version that just creates the desired CallInst directly.
Robertorosmaninho
requested changes
Jul 9, 2024
|
Don't worry at all; your suggestions do all make the code much nicer; I don't mind doing it and appreciate the thorough review. I believe I have now addressed all the issues. I will mark you for re-review as soon as I confirm that the tests are still passing. |
Robertorosmaninho
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we still had some references to typed pointers in .ll files and in API calls that still created typed pointers when working with older versions of LLVM. This led to some invalid bitcode being generated in ways that wasn't necessarily a problem, but which caused problems when I was making changes to that code. This PR is a preliminary to further changes which removes all remaining references to the API constructor for typed pointers and removes all typed pointers from flat bitcode files.