Update to latest master branch of immer #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating to the latest master branch of immer because the new_gc branch seems to need custom support from the immer library in order to be able to correctly evacuate map and set iterators that are roots on the stack. I want to make the changes to immer in a manner that is suitable for being merged upstream, so it will prove helpful to first be based on the latest master of immer.
Note we do not use the exact commit of the latest master, because it turns out the latest master includes some changes that introduce a regression for the
migrateRootsfunction in our llvm backend runtime which handles migrating global variable pointers into the kore heap. I had to make some minor tweaks to the immer library to make it work again, and thus I am currently pointing our submodule to our fork of immer, where I have pushed the changes I made. I already created a PR upstream in the immer repository (arximboldi/immer#189) which contains the changes I have made which I hope to get merged upstream. The plan is to point the submodule back at the upstream repository on the master branch once my changes get merged upstream.