Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache.zip in repo is that a problem or not #3433

Closed
rusefillc opened this issue Oct 30, 2021 · 9 comments · Fixed by #3639
Closed

cache.zip in repo is that a problem or not #3433

rusefillc opened this issue Oct 30, 2021 · 9 comments · Fixed by #3639

Comments

@rusefillc
Copy link
Contributor

we like to re-generate cache.zip somes a few times a day

cache.zip being a binary artifact is probably not good in terms of git practices and repo size

technically all we need is "cache" folder with files in it, not a zip achieve

@mck1117
Copy link
Contributor

mck1117 commented Oct 30, 2021

do we need a cache at all? Why not generate every time?

@rusefillc
Copy link
Contributor Author

We do not want signature to change without a reason I guess?

@mck1117
Copy link
Contributor

mck1117 commented Oct 30, 2021

But the signature is a function of the input files, right?

@mck1117
Copy link
Contributor

mck1117 commented Oct 30, 2021

just store a file last_signature.txt, and if the current signature doesn't match that, then generate the files

@rusefillc
Copy link
Contributor Author

huh? signature is random, it never matches?

@mck1117
Copy link
Contributor

mck1117 commented Oct 30, 2021

image

SIGNATURE_HASH is based only on the content of the input files, no random

@rusefillc
Copy link
Contributor Author

@andreika-git do you remember why do we need cache.zip?

@andreika-git
Copy link
Collaborator

@andreika-git do you remember why do we need cache.zip?

I don't remember why the file is stored in the repo. Maybe to allow local incremental gen_config calls? When I add something small to the config, I don't want to fully rebuild everything...

@mck1117
Copy link
Contributor

mck1117 commented Oct 31, 2021

We don't even use it for incremental rebuilds though, plus it's just not that slow to do a generate. ./gen_config_default.sh takes 2 seconds on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants