-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #29
Improve CI #29
Conversation
I don't know why but Windows CI doesn't work, I've installed |
vcpkg build packages from source code, so it will take a lot of time rather than apt in ubuntu. By default, vcpkg build both debug and release version. You can disable debug version by add |
Thank you for the advice! I'm going to add that later, but for now the problem is that I can't build the code. It seems there is an hindrance here |
I noticed CI log. There is a bug in vcpkg that the version info in opus.pc is "0". You may modify yourself, it's 1.3.1, I guess. |
How can I do that? |
the file vcpkg\installed\x64-windows\lib\pkgconfig\opus.pc . It looks like
Change Here is the issue and they fixed it but not merge yet. |
@asuper0 |
I find out that is because the config in libvpx. It is set to not build debug by default. |
So can I remove the
Perfect, let me see if I can remove the hack step from CI |
No, that can save time while building opus and other packages in the future. I advise to keep it. |
683269b
to
727664c
Compare
- Refactor Linux CI - Add Windows CI based on Mingw64 - Add a tutorial to README to build examples through vcpkg
Thank you for your review! I should have solved and clarified everything, as soon as you approve this PR I'm going to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good!
vcpkg