Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #29

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Improve CI #29

merged 1 commit into from
Aug 19, 2022

Conversation

Luni-4
Copy link
Member

@Luni-4 Luni-4 commented Aug 18, 2022

  • Refactor Linux CI
  • Add Windows CI based on Mingw64
  • Add a tutorial to README to build examples through vcpkg

@Luni-4
Copy link
Member Author

Luni-4 commented Aug 18, 2022

@asuper0

I don't know why but Windows CI doesn't work, I've installed pkg-config and it works and the two packages. I set up the environment variable but without any result. Do you know what could be the problem?

@asuper0
Copy link

asuper0 commented Aug 18, 2022

vcpkg build packages from source code, so it will take a lot of time rather than apt in ubuntu. By default, vcpkg build both debug and release version. You can disable debug version by add set(VCPKG_BUILD_TYPE release) to triplets/x64-windows.cmake , that would save time.

@Luni-4 Luni-4 changed the title Imorive CI Improve CI Aug 18, 2022
@Luni-4
Copy link
Member Author

Luni-4 commented Aug 18, 2022

vcpkg build packages from source code, so it will take a lot of time rather than apt in ubuntu. By default, vcpkg build both debug and release version. You can disable debug version by add set(VCPKG_BUILD_TYPE release) to triplets/x64-windows.cmake , that would save time.

Thank you for the advice! I'm going to add that later, but for now the problem is that I can't build the code. It seems there is an hindrance here

@asuper0
Copy link

asuper0 commented Aug 18, 2022

I noticed CI log. There is a bug in vcpkg that the version info in opus.pc is "0". You may modify yourself, it's 1.3.1, I guess.

@Luni-4
Copy link
Member Author

Luni-4 commented Aug 18, 2022

I noticed CI log. There is a bug in vcpkg that the version info in opus.pc is "0". You may modify yourself, it's 1.3.1, I guess.

How can I do that?

@asuper0
Copy link

asuper0 commented Aug 18, 2022

the file vcpkg\installed\x64-windows\lib\pkgconfig\opus.pc . It looks like

prefix=${pcfiledir}/../..
# Opus codec reference implementation pkg-config file

exec_prefix=${prefix}
libdir=${prefix}/lib
includedir=${prefix}/include

Name: Opus
Description: Opus IETF audio codec ( build)
URL: https://opus-codec.org/
Version: 0
Requires:
Conflicts:
Libs: -L"${prefix}/lib" -lopus
Libs.private: 
Cflags: -I"${prefix}/include/opus"

Change Version: 0 to Version: 1.3.1 or Version: 1.3.1-34-g5c94ec32

Here is the issue and they fixed it but not merge yet.
Issue

@Luni-4
Copy link
Member Author

Luni-4 commented Aug 18, 2022

@asuper0
Yeah, it works now! Unfortunately, I wasn't able to shatter down libvpx building time even though it seems we are in Release mode

@asuper0
Copy link

asuper0 commented Aug 19, 2022

I find out that is because the config in libvpx. It is set to not build debug by default.
BTW, the PR in vcpkg is merged today.

@Luni-4
Copy link
Member Author

Luni-4 commented Aug 19, 2022

I find out that is because the config in libvpx. It is set to not build debug by default.

So can I remove the set(VCPKG_BUILD_TYPE release) part?

BTW, the PR in vcpkg is merged today.

Perfect, let me see if I can remove the hack step from CI

@asuper0
Copy link

asuper0 commented Aug 19, 2022

So can I remove the set(VCPKG_BUILD_TYPE release) part?

No, that can save time while building opus and other packages in the future. I advise to keep it.

@Luni-4 Luni-4 force-pushed the windows-ci branch 2 times, most recently from 683269b to 727664c Compare August 19, 2022 09:03
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- Refactor Linux CI
- Add Windows CI based on Mingw64
- Add a tutorial to README to build examples through vcpkg
@Luni-4
Copy link
Member Author

Luni-4 commented Aug 19, 2022

@asuper0

Thank you for your review! I should have solved and clarified everything, as soon as you approve this PR I'm going to merge it.

@Luni-4 Luni-4 requested a review from asuper0 August 19, 2022 09:37
Copy link

@asuper0 asuper0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good!

@Luni-4 Luni-4 merged commit 6cbe8aa into master Aug 19, 2022
@Luni-4 Luni-4 deleted the windows-ci branch August 19, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants