Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecated Matroska Elements #133

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

FreezyLemon
Copy link
Contributor

Closes #117.

There was a bug in skip_master (now skip_element) where it didn't skip all of the Element data which was easy to fix.

Also removed some serialization functions that aren't used anymore.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: +1.64 🎉

Comparison is base (8944849) 46.84% compared to head (703875e) 48.49%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   46.84%   48.49%   +1.64%     
==========================================
  Files          14       14              
  Lines        2741     2584     -157     
==========================================
- Hits         1284     1253      -31     
+ Misses       1457     1331     -126     
Impacted Files Coverage Δ
src/ebml/mod.rs 25.00% <ø> (ø)
src/elements.rs 33.48% <ø> (+2.46%) ⬆️
src/muxer.rs 0.00% <ø> (ø)
src/serializer/cookie_utils.rs 59.75% <ø> (+2.10%) ⬆️
src/serializer/ebml.rs 86.23% <ø> (+6.23%) ⬆️
src/serializer/elements.rs 14.65% <0.00%> (+1.52%) ⬆️
src/permutation.rs 86.48% <80.00%> (-2.09%) ⬇️
src/demuxer.rs 88.18% <100.00%> (-0.74%) ⬇️
src/ebml/parse.rs 90.90% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This is really fantastic!

Just a simple nit

src/permutation.rs Show resolved Hide resolved
@Luni-4 Luni-4 merged commit 7f15b7c into rust-av:master Apr 27, 2023
@FreezyLemon FreezyLemon deleted the handle-reclaimed-elements branch April 27, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing outdated/deprecated Matroska Elements
3 participants