Skip to content

Simplify #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2019
Merged

Simplify #126

merged 2 commits into from
Apr 16, 2019

Conversation

thomasmulvaney
Copy link
Member

@dlaehnemann mentioned the messy if and let expressions in #125. I think this probably makes things a little nicer.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 593

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 48.457%
Totals Coverage Status
Change from base Build 590: 0.002%
Covered Lines: 13395
Relevant Lines: 27643
💛 - Coveralls

dlaehnemann
dlaehnemann approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! This looks much more Rusty. Had been trying to come up with a more elegant syntax, but...

@dlaehnemann dlaehnemann merged commit fd7afa8 into master Apr 16, 2019
@dlaehnemann dlaehnemann mentioned this pull request Apr 16, 2019
Merged
@thomasmulvaney thomasmulvaney deleted the simplify branch April 16, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlaehnemann dlaehnemann dlaehnemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasmulvaney @coveralls @dlaehnemann