Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 0.10.0-beta.2 for the upcoming release #170

Merged

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jan 16, 2024

We just bumped the version number to 0.10.0-beta2 but that format causes cargo to automatically pull the new version. We can use 0.10.1-beta.2 so cargo correctly treats it as a new separate version.

We just bumped the version number to `0.10.0-beta2` but that format
causes `cargo` to automatically pull the new version. We can use
`0.10.1-beta.2` so `cargo` correctly treats it as a new separate
version.
@tcharding tcharding changed the title Bump version to 0.10.0-beta.2 Use 0.10.0-beta.2 for the upcoming release Jan 16, 2024
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 15dfdf0

@apoelstra apoelstra merged commit d9b727b into rust-bitcoin:master Jan 17, 2024
12 checks passed
@apoelstra
Copy link
Member

Published and yanked :( same issue.

I think I'll just try to use this version in Elements locally (I think cargo will let me use a yanked version, it'll just whine about it) and if that passes let's just do a real release.

@apoelstra apoelstra deleted the 01-17-release-0.10.0-beta.2 branch January 17, 2024 15:24
@apoelstra
Copy link
Member

Ok, cargo won't let me use the yanked version, but I can use my local repo.

@apoelstra
Copy link
Member

Ok, I have two comments so far:

  • The signature is wrong on data_part_ascii_no_checksum. It returns a &[u8] (which defaults to the lifetime on &self) but needs to return &'s [u8]. Probably same with the other accessors. Without this fix I get borrowck errors all over the place.
  • I would actually like a Fe32 iterator on CheckedHrpString; this is the intermediate iterator used in constructing the return value of byte_iter so it'll be easy to implement.

Also it would make my life a tiny bit easier if validate_padding and validate_witness_program_length were pub ... but I don't think we want to do that, it'd make the API too messy and expose too many internals.

@tcharding
Copy link
Member Author

tcharding commented Jan 17, 2024

I"ll work on the points above. As far as naming, shall we just use -gamma like you said before. This is slightly amusing that with our combined number of years writing rust we are having so much difficulty naming a new 'beta' version'.

@apoelstra
Copy link
Member

I'm doubtful that gamma will work when beta2 didn't, but we might as well try it!

@tcharding
Copy link
Member Author

tcharding commented Jan 18, 2024

Want to just test the new stuff locally on your end (i.e., after that new stuff above) and then just release the v0.10.0?

@apoelstra
Copy link
Member

Yeah, I think that's best. Next time we'll try starting with beta.0 etc and see if that works.

@tcharding
Copy link
Member Author

Ok, I have two comments so far:

  • The signature is wrong on data_part_ascii_no_checksum. It returns a &[u8] (which defaults to the lifetime on &self) but needs to return &'s [u8]. Probably same with the other accessors. Without this fix I get borrowck errors all over the place.
  • I would actually like a Fe32 iterator on CheckedHrpString; this is the intermediate iterator used in constructing the return value of byte_iter so it'll be easy to implement.

Also it would make my life a tiny bit easier if validate_padding and validate_witness_program_length were pub ... but I don't think we want to do that, it'd make the API too messy and expose too many internals.

All this should be seen to now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants