Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.14.0 #102

Closed
popzxc opened this issue Jun 27, 2018 · 8 comments
Closed

Bump version to 0.14.0 #102

popzxc opened this issue Jun 27, 2018 · 8 comments
Milestone

Comments

@popzxc
Copy link
Contributor

popzxc commented Jun 27, 2018

Current version of rust-bitcoin has some new features (Regtest network, consensus parameters, corrected multiplication).

Would it make sense to bump the version of crate?

@apoelstra
Copy link
Member

Yes. I will do that in a PR right before release.

We haven't really figured out a good process for this. I guess when we bump to 0.14, we should add an additional commit that bumps to "0.15-pre" or something, and then bump to 0.15 before publishing?

I agree that the current situation, where the git repo says 0.13 but we have breaking changes since the published 0.13, seems wrong.

@popzxc
Copy link
Contributor Author

popzxc commented Jun 28, 2018

Well, in exonum we have a CHANGELOG.md file which is updated in every PR. So, at the every point we have an actual list of changes for the current commit. Before release they are stored in [Unreleased] and on release it's just renamed to the appropriate version.

So, when user wants to check if he is able to use this version or not, he can just look at [Unreleased] section of changelog.

I guess some similar process will be enough here too.

@apoelstra
Copy link
Member

Sure, I like that. Alongside 0.14.0 I'll create such a file and require updates in any PRs that change semantics.

@popzxc
Copy link
Contributor Author

popzxc commented Jun 30, 2018

I'd suggest to create a CONTRIBUTING.md file with information for external contributors, so such a requirements won't be a surprice for them.

@popzxc
Copy link
Contributor Author

popzxc commented Jul 21, 2018

I don't want to be intrusive, but @apoelstra could you please tell me when approximately version will be bumped? We need a release to use some of new features.

@apoelstra
Copy link
Member

Today or tomorrow I should have time to go through everything outstanding in rust-bitcoin and rust-secp.

I want to release a new version of rust-secp soon that will overhaul the API, and to update rust-bitcoin to use this also in 0.14.

@apoelstra apoelstra mentioned this issue Jul 25, 2018
5 tasks
@apoelstra
Copy link
Member

Once we have #125 (serde 1.0) and #113 (secp256k1 0.10) I'll release 0.14.

I'd prefer not to release without secp 0.10, since it would make the latest versions of rust-bitcoin and rust-secp incompatible, and merging secp 0.10 (which is ready) without serde 1.0 (which is not) would cause grief for serde users.

@ariard
Copy link
Contributor

ariard commented Aug 13, 2018

Really cool, waiting Regtest support to play with it on rust-lightning-bitcoinrpc :)

@apoelstra apoelstra added this to the 0.14 milestone Aug 20, 2018
Tibo-lg pushed a commit to p2pderivatives/rust-bitcoin that referenced this issue Sep 1, 2020
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this issue Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants