Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoding/encoding PSBT #187

Open
Kixunil opened this issue Jul 18, 2021 · 0 comments
Open

Decoding/encoding PSBT #187

Kixunil opened this issue Jul 18, 2021 · 0 comments

Comments

@Kixunil
Copy link

Kixunil commented Jul 18, 2021

I looked at changing the API to encode/decode PSBTs, which would be much more convenient and less error-prone, however I hit this problem:

the trait `Eq` is not implemented for `PartiallySignedTransaction`

So it seems requests and responses derive Eq. I'm not sure what's the best way to approach this:

  • Remove Eq from requests and responses - hopefully nobody uses them as keys into maps?
  • impl Eq for PartiallySignedTransaction in rust-bitcoin, but why it isn't there already?
  • impl Eq for ... manually (no derive), but maybe it's incorrect for the same reason it's already not present on PartiallySignedTransaction?
  • Give up - maybe what I'm doing is not that great idea? :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kixunil