Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed useless Makefile #349

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Removed useless Makefile #349

merged 1 commit into from
Jan 4, 2022

Conversation

Kixunil
Copy link
Collaborator

@Kixunil Kixunil commented Jan 4, 2022

This Makefile did nothing interesting and could confuse people.

@Kixunil
Removed useless Makefile
fafc141 
This Makefile did nothing interesting and could confuse people.
@real-or-random
Copy link
Collaborator

Fine with me. We don't need it.

apoelstra
apoelstra approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fafc141

lol, in my entire tenure maintaining this project I have never noticed that this file existed. It dates back to the very first commit by dpc in 2014.

@apoelstra apoelstra merged commit 45bf2d3 into rust-bitcoin:master Jan 4, 2022
@apoelstra
Copy link
Member

Not gonna bother updating the changelog in #347

@Kixunil Kixunil deleted the remove-makefile branch January 4, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kixunil @real-or-random @apoelstra