-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the stm32h7xx-hal crate #209
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hargoniX, a couple quick comments/questions:
- You mention that beta or nightly is required in the readme, what's the reason for that? (I don't think we have a hard rule that crates have to be stable-only, but most are nowadays)
- The docs for your crate aren't currently building, due to a timeout on docs.rs. Based on the build logs, it seems your build is timing out, which is a thing that embedded crates do sometimes. There is a link there to open an issue and ask for a longer timeout so that you can get your builds fixed.
For the first question, our current README on GitHub removed that note but it was due to the type_alias_enum_variant feature gate which has been stabilized in 1.37, I'll look into why the README isn't up to date on crates.io I'll look into that asap, thanks for pointing it out! |
@jamesmunns Both of your concerns should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for fixing those!
bors r+
Build succeeded |
I'm one of the co authors and I think with the release 0.2.0 which just came out the other day this HAL is now in a pretty solid and ready to use state.