Skip to content

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Dec 20, 2019

I just released this driver. I added the link together with my other two links for grouping reasons but it is also fine for me to put it after Nick Ray's links.
Please let me know if you think it would be better to change the order.

@eldruin eldruin requested a review from a team as a code owner December 20, 2019 21:45
@rust-highfive
Copy link

r? @andre-richter

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@andre-richter andre-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, basically looks good.

If you want, you can try rephrasing the part I highlighted if my comment makes sense to you. If you say it should stay that way, I'll approve as well. Your choice.

Copy link
Member

@andre-richter andre-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Dec 21, 2019
91: Add VEML6030 ambient light sensor r=andre-richter a=eldruin

I just released this driver. I added the link together with my other two links for grouping reasons but it is also fine for me to put it after Nick Ray's links.
Please let me know if you think it would be better to change the order.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 21, 2019

Build succeeded

@bors bors bot merged commit 54f5e93 into rust-embedded:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants