Skip to content

Remove nomem flag from isb, dsb and dmb #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jannic
Copy link
Member

@jannic jannic commented Apr 16, 2024

Probably not as important on 0.7 as on the main branch: The precompiled functions are not affected, and the inline ones are protected by additional compiler_fence calls, so the compiler can't reorder anyway. Still better to conform to the reference and not use nomem on assembly blocks that are used for synchronization.

Fixes #502

@jannic jannic requested a review from a team as a code owner April 16, 2024 19:43
@adamgreig adamgreig merged commit 1ef0864 into rust-embedded:v0.7.x Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants