Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license file to the top-level directory. #589

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jannic
Copy link
Member

@jannic jannic commented Apr 16, 2024

These files are referenced from README.md, so they should be present.

The same files are already available in the individual crates, so another possibility would be linking to one of the subdirectories.

I think it's preferable to have them at the top-level for better visibility.

Fixes #588

@jannic jannic requested a review from a team as a code owner April 16, 2024 18:49
@jannic
Copy link
Member Author

jannic commented Apr 16, 2024

Don't worry (too much) about the CI failures.
They are caused by a new warning (and we set -D warnings), but it looks like that warning caused too many issues so it'll probably be reverted. See rust-lang/rust#121708 for more information. The latest comments suggest that the warning has already been disabled in beta.

EDIT: Fixed by #590

These files are referenced from README.md, so they should be present.

The same files are already available in the individual crates, so
another possibility would be linking to one of the subdirectories.

I think it's preferable to have them at the top-level for better
visibility.

Fixes rust-embedded#588
@Dirbaio Dirbaio added this pull request to the merge queue Apr 16, 2024
Merged via the queue into rust-embedded:master with commit 88f63d4 Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: Links to LICENSE-APACHE and LICENSE-MIT are not found
2 participants