Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enable_cs to safely enable interrupts #4

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Add enable_cs to safely enable interrupts #4

merged 1 commit into from
Mar 29, 2020

Conversation

YuhanLiin
Copy link
Contributor

Add a new function to safely enable interrupts by consuming a CriticalSection, which is provided in main() and interrupt handlers in the newest versions of msp430-rt.

@YuhanLiin YuhanLiin requested a review from a team as a code owner March 26, 2020 22:18
@YuhanLiin
Copy link
Contributor Author

@cr1901 @pftbest Does this look reasonable?

@cr1901
Copy link
Contributor

cr1901 commented Mar 29, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 29, 2020

Build succeeded

@bors bors bot merged commit 27ccd59 into rust-embedded:master Mar 29, 2020
@cr1901
Copy link
Contributor

cr1901 commented Dec 23, 2021

@YuhanLiin I believe enable_cs is unsound in its current form and should be outright removed in a breaking change/minor version bump. See rust-embedded/bare-metal#42 for discussion.

@YuhanLiin YuhanLiin deleted the enable_cs branch December 24, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cr1901 cr1901 cr1901 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuhanLiin @cr1901