Fix: Don't crash when target-feature=+relax is given #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
romancardenas
requested changes
Sep 29, 2025
There was a problem hiding this comment.
Thanks for your contribution!
Apart from my comment about double negative clauses, please, address the following issues:
- Add a small entry in
riscv-target-parser/CHANGELOG.mdto describe the changes. - Make all the required changes to make clippy happy: https://github.com/rust-embedded/riscv/actions/runs/18076762062/job/51463063101?pr=349
This target feature is a bit unusual in that it does not refer to actual hardware features, but is rather a target-specific linker feature. See also rust-lang/rust#109860
wisp3rwind
force-pushed
the
support-relax
branch
from
021bedf to
dd626f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is a bit unusual in that it does not refer to actual hardware features, but is rather a target-specific linker feature. This PR simply skips this feature when building
RiscvTarget, since from my understanding, it is irrelevant here.See also rust-lang/rust#109860