Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation tutorial 3 #167

Merged
merged 7 commits into from
Sep 22, 2022
Merged

Translation tutorial 3 #167

merged 7 commits into from
Sep 22, 2022

Conversation

Jzow
Copy link
Contributor

@Jzow Jzow commented Aug 9, 2022

Description

Related Issue:

Pre-commit steps

  • Tested on QEMU and real HW Rasperry Pi.
    • Not needed if it is just a README change or similar.
  • Ran ./contributor_setup.sh followed by ./devtool ready_for_publish
    • You'll need Ruby with Bundler and NPM installed locally.
    • If no Rust-related files were changed, ./devtool ready_for_publish_no_rust can be used instead (faster).
    • This step is optional, but much appreciated if done.

@Jzow
Copy link
Contributor Author

Jzow commented Aug 9, 2022

#166

@andre-richter
Copy link
Member

Thanks! Do you have somebody for proofreading?

CC @colachg @readlnh

Copy link
Contributor

@colachg colachg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jzow , I have given some comments. Thanks for your work :)

03_hacky_hello_world/README.CN.md Outdated Show resolved Hide resolved
03_hacky_hello_world/README.CN.md Outdated Show resolved Hide resolved
03_hacky_hello_world/README.CN.md Show resolved Hide resolved
03_hacky_hello_world/README.CN.md Show resolved Hide resolved
@Jzow
Copy link
Contributor Author

Jzow commented Aug 17, 2022

@colachg Thank you for reviewing, I try to modify

@Jzow
Copy link
Contributor Author

Jzow commented Sep 11, 2022

@colachg Hi, I have tried to modify it. Can you review it again? If ok, I will continue to translate the following chapters

@colachg
Copy link
Contributor

colachg commented Sep 11, 2022

@colachg Hi, I have tried to modify it. Can you review it again? If ok, I will continue to translate the following chapters

Of course yes , can you please resolve all the comments that I left above if you have modified it or even you don't want to modify it?
@Jzow

@Jzow
Copy link
Contributor Author

Jzow commented Sep 11, 2022

can you please resolve all the comments

please check, I have modified it and resolve all

Copy link
Contributor

@colachg colachg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@andre-richter andre-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see m comment regarding the diff section that was falsely marked as resolved.

@Jzow
Copy link
Contributor Author

Jzow commented Sep 13, 2022

Please check the english version, which is kept up-to-date.

Don't have to translate this sentence into Chinese? My understanding is that it can be linked to the English version of diff, which can be seen clearly by users. This sentence should be translated

If necessary, I will make another modification

@colachg What do you think?

@andre-richter
Copy link
Member

Okay for me to translate this sentence 👍

@andre-richter
Copy link
Member

Please open one PR per chapter. That makes reviewing easier for others.

It seems that for tutorial 3, you still have the English sentence for

Please check the english version, which is kept up-to-date.

In tutorial 4, it is translated already.

@Jzow
Copy link
Contributor Author

Jzow commented Sep 19, 2022

First, I temporarily removed the translation in Chapter 4, and then opened a new pr for each translation in Chapter 4. In addition, I modified the diff in Chapter 2 and Chapter 3

@andre-richter andre-richter merged commit c8c422e into rust-embedded:master Sep 22, 2022
@andre-richter
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants