Assume ARMv6 when <cpu> section is missing
#143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the generated crates build in more cases
japaric
reviewed
Sep 19, 2017
src/generate.rs
Outdated
| match *target { | ||
| Target::CortexM => { | ||
| let is_armv6 = match device.cpu { | ||
| Some(ref cpu) if cpu.name.starts_with("CM0") => true, |
There was a problem hiding this comment.
Could the first two arms be merged into Some(ref cpu) => cpu.starts_with("CM0")?
And I think it would be better (for readability) to explicitly write None in the third arm.
|
@homunkulus delegate+ @jonas-schievink you can r+ this PR once you do the change (if it makes sense to change it) if I'm not around by then. |
|
✌️ @jonas-schievink can now approve this pull request |
|
Done! @homunkulus r+ |
|
📌 Commit 8b3b278 has been approved by |
japaric
pushed a commit
that referenced
this pull request
Sep 20, 2017
Assume ARMv6 when `<cpu>` section is missing This makes the generated crates build in more cases.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the generated crates build in more cases.