Skip to content

Conversation

japaric
Copy link
Member

@japaric japaric commented Nov 11, 2018

No description provided.

@japaric japaric requested a review from a team as a code owner November 11, 2018 23:23
@japaric
Copy link
Member Author

japaric commented Nov 11, 2018

bors try

bors bot added a commit that referenced this pull request Nov 11, 2018
@bors
Copy link
Contributor

bors bot commented Nov 11, 2018

try

Build succeeded

therealprof
therealprof previously approved these changes Nov 11, 2018
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much.

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Nov 11, 2018
255: [WIP] move windows ci to travis r=therealprof a=japaric



Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@japaric
Copy link
Member Author

japaric commented Nov 11, 2018

@therealprof hold your horses. Most build jobs are currently disabled in this PR.

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 11, 2018

Canceled

@japaric
Copy link
Member Author

japaric commented Nov 11, 2018

Windows releases appear to work. I'll re-enable all the non-windows build jobs and then this can be r+-ed.

@japaric
Copy link
Member Author

japaric commented Nov 11, 2018

re-r? @therealprof

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! I was going to ask what you planned to do with all the comments. ;)

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Nov 12, 2018
255: [WIP] move windows ci to travis r=therealprof a=japaric



Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Nov 12, 2018

Build succeeded

@bors bors bot merged commit 16e5032 into master Nov 12, 2018
@bors bors bot deleted the ci branch November 12, 2018 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants