Sort registers by address_offset before checking for overlap. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I think this should fix #26 cc @phil-opp @homunkulus r+ |
|
📌 Commit 9010fec has been approved by |
japaric
pushed a commit
that referenced
this pull request
Nov 20, 2016
…lap, r=japaric Sort registers by address_offset before checking for overlap. This was a problem for example when generating the map for NVIC on the STM32F303x, where most registers would be discarded because STIR is listed first, before all ISERx fields.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a problem for example when generating the map for NVIC on the STM32F303x, where
most registers would be discarded because STIR is listed first, before all ISERx fields.