Skip to content

Conversation

therealprof
Copy link
Contributor

I refactored some quasi-quoted code to make it a more more forward compatible with newer versions of the syn and quote crates which we'll probably want to move to at some point.

r? @ryankurte

The latter takes more arguments in newer syn versions and `from` happens
to work now and in the next release(s).

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof therealprof requested a review from a team as a code owner July 23, 2019 22:48
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 23, 2019
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

bors bot added a commit that referenced this pull request Jul 24, 2019
330: Branch/indent refactoring r=adamgreig a=therealprof

I refactored some quasi-quoted code to make it a more more forward compatible with newer versions of the syn and quote crates which we'll probably want to move to at some point.

r? @ryankurte 

Co-authored-by: Daniel Egger <daniel@eggers-club.de>
@bors
Copy link
Contributor

bors bot commented Jul 24, 2019

Build succeeded

@bors bors bot merged commit 1c32ddd into master Jul 24, 2019
@bors bors bot deleted the branch/indent-refactoring branch July 24, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants