Skip to content

Conversation

therealprof
Copy link
Contributor

A series of patches to bring it a bit more up-to-date. Includes:

  • making it Edition-2018
  • bumping a few dependencies
  • fixing all clippy lints
  • changing to the master branch (instead of the ghost branch python-0.4 which can only be found by GitHub somehow) of the cmsis-svd repository
  • allowing cargo init on weirdly named SVD files
  • fixed NXP company name so SVD files can actually be downloaded
  • weeded out old STM SVD filenames and added some new ones

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
I wonder how that might have ever resulted in a working URL

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof therealprof requested a review from a team as a code owner July 28, 2019 19:29
@rust-highfive
Copy link

r? @Emilgardis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 28, 2019
@adamgreig
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jul 28, 2019
@bors
Copy link
Contributor

bors bot commented Jul 28, 2019

try

Build succeeded

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@adamgreig adamgreig mentioned this pull request Jul 28, 2019
bors bot added a commit that referenced this pull request Jul 29, 2019
344: Join the bits muching into a single line to improve dev builds r=adamgreig a=therealprof

Also this rectifies many of the tons of
https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
lints we're getting.

Signed-off-by: Daniel Egger <daniel@eggers-club.de>

346: Modernize svd2rust regress r=adamgreig a=therealprof

A series of patches to bring it a bit more up-to-date. Includes:
* making it Edition-2018
* bumping a few dependencies
* fixing all clippy lints
* changing to the master branch (instead of the ghost branch python-0.4 which can only be found by GitHub somehow) of the `cmsis-svd` repository
* allowing `cargo init` on weirdly named SVD files
* fixed NXP company name so SVD files can actually be downloaded
* weeded out old STM SVD filenames and added some new ones

Co-authored-by: Daniel Egger <daniel@eggers-club.de>
@bors
Copy link
Contributor

bors bot commented Jul 29, 2019

Build succeeded

@bors bors bot merged commit 0637dc0 into master Jul 29, 2019
@bors bors bot deleted the modernize-svd2rust-regress branch July 29, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants