Skip to content

Conversation

nickray
Copy link
Contributor

@nickray nickray commented Aug 14, 2019

Example: "normally or power-up" gave "NORMALLYORPOWER-UP" which doesn't work.

@nickray nickray requested a review from a team as a code owner August 14, 2019 19:45
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Aug 14, 2019
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Aug 14, 2019
377: Sanitize names from dashes r=therealprof a=nickray

Example: "normally or power-up" gave "NORMALLYORPOWER-UP" which doesn't work.

Co-authored-by: Nicolas Stalder <n@stalder.io>
@bors
Copy link
Contributor

bors bot commented Aug 14, 2019

Build succeeded

@bors bors bot merged commit 2061b84 into rust-embedded:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants