Skip to content

enum descriptions #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2019
Merged

enum descriptions #379

merged 1 commit into from
Aug 15, 2019

Conversation

burrbull
Copy link
Member

r? @therealprof
cc @Disasm

Before:
изображение

After:
after1

@burrbull burrbull requested a review from a team as a code owner August 15, 2019 06:00
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Aug 15, 2019
therealprof
therealprof approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

therealprof
therealprof requested changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Changelog entry though. ;)

@burrbull
Copy link
Member Author

Done.

therealprof
therealprof approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Aug 15, 2019
@bors @burrbull
Merge #379
e1b4b20 
379: enum descriptions r=therealprof a=burrbull

r? @therealprof 
cc @Disasm 

Before:
![изображение](https://user-images.githubusercontent.com/3072754/63075646-0470fc80-bf3b-11e9-8383-bccb9096db1b.png)

After:
![after1](https://user-images.githubusercontent.com/3072754/63075663-13f04580-bf3b-11e9-839a-7a87adc3399f.png)


Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 15, 2019

Build succeeded

@bors bors bot merged commit 220ea14 into rust-embedded:master Aug 15, 2019
@burrbull burrbull deleted the descriptions branch August 15, 2019 10:19
@Disasm
Copy link
Member

Disasm commented Aug 15, 2019

I wonder if this "Bit 0" in the description is not confusing here. The same enum can be used for multiple locations with different bit offsets.

@burrbull
Copy link
Member Author

You are right. I'll try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@burrbull @therealprof @Disasm @rust-highfive