Option-like API for variant #383
Conversation
rust-highfive
added
S-waiting-on-review
|
Interesting, what's the intended use for that? |
src/generate/generic.rs
Outdated
| pub fn unwrap(self) -> T { | ||
| match self { | ||
| Val(v) => v, | ||
| Res(u) => panic!("Unexpected variant: {:?}", u), |
There was a problem hiding this comment.
I'm not to hot about this panic! and the expect method below. If this ends up in use in real code it'd add significant bloat.
There was a problem hiding this comment.
I can remove unwrap and keep expect as it is more explicit.
There was a problem hiding this comment.
I'm fine with with those methods per se but let's get rid of the formatting and the Debug bound, please.
|
Sometimes enumeratedValues does not cover all variants of bits (number of variants less then 2^field_width). But if you want to get variant as |
This comment has been minimized.
This comment has been minimized.
src/generate/generic.rs
Outdated
| use Variant::*; | ||
| impl<U, T> Variant<U, T> { | ||
| /// Check if the variant is expected | ||
| pub fn is_value(&self) -> bool { |
There was a problem hiding this comment.
This naming is strange. At least function name does not correspond to the docs. I can't suggest anything nicer, though.
There was a problem hiding this comment.
Do you have suggestions?
| /// | ||
| /// Panics if the value is an `Res`, with a panic message including the | ||
| /// passed message, and the content of the `Res`. | ||
| pub fn expect(self, msg: &'static str) -> T { |
There was a problem hiding this comment.
Do you really need 'static bound here?
There was a problem hiding this comment.
It doesn’t compile without 'static.
There was a problem hiding this comment.
Weird. The original expect doesn't have it.
There was a problem hiding this comment.
I think it's because original expect use formatted panic!("{}", msg).
With 2 arguments.
|
Rebased. |
|
See #496 |
4 participants
r? @therealprof
cc @Disasm