This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Use ECDSA APIs from k256 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorot93
force-pushed
the
vorot93/new-k256-apis
branch
from
9eab8fa to
9e060bd
Compare
tarcieri
reviewed
Sep 25, 2020
tarcieri
approved these changes
Sep 25, 2020
Co-authored-by: Tony Arcieri <bascule@gmail.com>
AgeManning
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k256 v0.5 has introduced new ECDSA APIs which are a lot more straightforward to use. This PR replaces implementation of
EnrKeyandEnrPublicKeyfor low-level primitives with these, which are more aligned with our use case.My gratitude to @tarcieri for guidance on correct API usage.