feat: expose evm internal fns #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
reviewed
Sep 28, 2021
src/executor/mod.rs
Outdated
| @@ -3,7 +3,7 @@ | |||
| //! Executors are structs that hook gasometer and the EVM core together. It | |||
| //! also handles the call stacks in EVM. | |||
|
|
|||
| mod stack; | |||
| pub mod stack; | |||
|
|
|||
| pub use self::stack::{ | |||
| MemoryStackState, Precompile, PrecompileOutput, StackExecutor, StackExitKind, StackState, | |||
There was a problem hiding this comment.
Would you mind to export MemoryStackAccount here instead?
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Sep 30, 2021
requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged
sorpaas
reviewed
Sep 30, 2021
| }; | ||
|
|
||
| pub use ethereum::Log; |
There was a problem hiding this comment.
Because of this. Ideally I'd like to avoid having to import ethereum explicitly in my crate and have to manage its version & make sure it's in line with sputnik's.
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Sep 30, 2021
requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Sep 30, 2021
* feat: create cheatcode module * feat import MemoryStackState from upstream * feat(memory-stack-state-owned): modify to own the backend type requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged * feat(backend): add cheatcode backend (wrapper around backends) * feat(evm): generalize Sputnik's stack executor to trait This will allow us to instantiate the Sputnik EVM executor with a cheatcode-enabled one * feat(handler): add cheatcode handler to apply cheatcodes dynamically * feat(CheatcodeHandler): first pass at implementing SputnikExecutor * feat: import upstream transact_call * fix: modify transact_call to use newly exposed handler methods * feat: import upstream call_inner * fix: modify `call_inner` to use newly exposed handler methods * feat: enable cheatcode via Solidity * chore: cargo fmt * chore: remove unused tracing and dbg macros * feat: enable roll and warp cheatcodes * chore: upgrade ethers to allow short human readable function sigs * chore: cargo fmt * feat: add helper function for instantiating cheatcode evm * feat(cli): enable cheatcodes * chore: bump deps
|
Bump! |
|
Sorry for taking so long. I'll have to add |
|
Sounds great to me. Thank you! |
gakonst
force-pushed
the
chore/expose-stack-module
branch
from
bbb1ba1
to
8e10066
Compare
If 3rd parties want to build custom stack executors or stack states, they will need access to the datatypes defined inside this module
gakonst
force-pushed
the
chore/expose-stack-module
branch
from
8e10066
to
625dccc
Compare
|
Let me get the no_std tests later. |
sorpaas
reviewed
Oct 7, 2021
|
Everything else looks good. |
|
@sorpaas I have removed the default impl - anything else I can do to move the PR forward? |
|
Please fix lints. |
sorpaas
approved these changes
Oct 12, 2021
|
|
|
That's a mistake of mine. I'll revert it. |
Merged
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
* feat: create cheatcode module * feat import MemoryStackState from upstream * feat(memory-stack-state-owned): modify to own the backend type requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged * feat(backend): add cheatcode backend (wrapper around backends) * feat(evm): generalize Sputnik's stack executor to trait This will allow us to instantiate the Sputnik EVM executor with a cheatcode-enabled one * feat(handler): add cheatcode handler to apply cheatcodes dynamically * feat(CheatcodeHandler): first pass at implementing SputnikExecutor * feat: import upstream transact_call * fix: modify transact_call to use newly exposed handler methods * feat: import upstream call_inner * fix: modify `call_inner` to use newly exposed handler methods * feat: enable cheatcode via Solidity * chore: cargo fmt * chore: remove unused tracing and dbg macros * feat: enable roll and warp cheatcodes * chore: upgrade ethers to allow short human readable function sigs * chore: cargo fmt * feat: add helper function for instantiating cheatcode evm * feat(cli): enable cheatcodes * chore: bump deps
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
* feat: create cheatcode module * feat import MemoryStackState from upstream * feat(memory-stack-state-owned): modify to own the backend type requires using our patch of the upstream evm until rust-ethereum/evm#62 is merged * feat(backend): add cheatcode backend (wrapper around backends) * feat(evm): generalize Sputnik's stack executor to trait This will allow us to instantiate the Sputnik EVM executor with a cheatcode-enabled one * feat(handler): add cheatcode handler to apply cheatcodes dynamically * feat(CheatcodeHandler): first pass at implementing SputnikExecutor * feat: import upstream transact_call * fix: modify transact_call to use newly exposed handler methods * feat: import upstream call_inner * fix: modify `call_inner` to use newly exposed handler methods * feat: enable cheatcode via Solidity * chore: cargo fmt * chore: remove unused tracing and dbg macros * feat: enable roll and warp cheatcodes * chore: upgrade ethers to allow short human readable function sigs * chore: cargo fmt * feat: add helper function for instantiating cheatcode evm * feat(cli): enable cheatcodes * chore: bump deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 3rd parties want to build custom stack executors or stack states, they will need access to the datatypes defined inside this module
also adds
auto_implto implement common traits forBox,Arc,&and&mutvariants.