Skip to content

Conversation

@sorpaas
Copy link
Member

@sorpaas sorpaas commented Oct 22, 2021

It's not no_std compatible. We still need to work on the no_std CI to make sure this does not happen again. rel #62 (comment)

@gakonst
Copy link
Contributor

gakonst commented Oct 22, 2021

Can't we do cfg_attr(feature = "no_std", auto_impl(...)) as suggested here?

@sorpaas
Copy link
Member Author

sorpaas commented Oct 22, 2021

I'd prefer if we fix auto_impl since this should clearly be no_std compatible (all the types exist in no_std). Let me know if this is something you need urgently, otherwise I'd prefer to fix our CI first to make sure it does not happen again.

@sorpaas
Copy link
Member Author

sorpaas commented Oct 22, 2021

Also if this is not too complicated -- maybe consider manually implementing them!

@gakonst
Copy link
Contributor

gakonst commented Oct 22, 2021

No worries - I am OK with just using a patched version of this repo for now. I will investigate if fixing making auto_impl no_std compatible is something I'll have the capacity to do!

@sorpaas sorpaas merged commit c5c69e0 into master Oct 22, 2021
@sorpaas sorpaas deleted the sp-remove-auto-impl branch October 22, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants