-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve default_target to respect current toolchain and config #365
Open
taiki-e
wants to merge
1
commit into
rust-fuzz:main
Choose a base branch
from
taiki-e:default-target
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,20 @@ | ||
use std::sync::OnceLock; | ||
|
||
/// The default target to pass to cargo, to workaround issue #11. | ||
pub fn default_target() -> &'static str { | ||
current_platform::CURRENT_PLATFORM | ||
// Use OnceLock because clap's default_value only accepts reference. | ||
static DEFAULT_TARGET: OnceLock<String> = OnceLock::new(); | ||
DEFAULT_TARGET.get_or_init(|| { | ||
let config = cargo_config2::Config::load().unwrap(); | ||
// Get the target specified in config. | ||
let mut targets = config.build_target_for_cli(None::<&str>).unwrap(); | ||
if targets.len() > 1 { | ||
// Config can contain multiple targets, but we don't support it: https://doc.rust-lang.org/cargo/reference/config.html#buildtarget | ||
panic!("multi-target build is not supported: {targets:?}"); | ||
} | ||
targets | ||
.pop() | ||
// Get the host triple if the target is not specified in config. | ||
.unwrap_or_else(|| config.host_triple().unwrap().to_owned()) | ||
Comment on lines
+11
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this would be cleaner as |
||
}) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's return a result from this function and properly propagate errors rather than panicking here.