Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release N50 #1496

Merged
merged 23 commits into from
May 3, 2024
Merged

Release N50 #1496

merged 23 commits into from
May 3, 2024

Conversation

janhohenheim
Copy link
Collaborator

@janhohenheim janhohenheim commented Apr 29, 2024

Resolves #1474

Scheduled for 2024-05-03

content/news/050/index.md Outdated Show resolved Hide resolved
content/news/050/index.md Outdated Show resolved Hide resolved
content/news/050/index.md Outdated Show resolved Hide resolved
janhohenheim and others added 3 commits April 30, 2024 22:51
Co-authored-by: Thierry Berger <contact@thierryberger.com>
@janhohenheim janhohenheim marked this pull request as ready for review April 30, 2024 21:10
@janhohenheim
Copy link
Collaborator Author

janhohenheim commented Apr 30, 2024

Initial version is done; feedback is welcome :)
If you approve it, please don't merge it yet. Let me do that on the 3rd.
Also tell me if I should change something in the survey

@janhohenheim janhohenheim mentioned this pull request Apr 30, 2024
20 tasks
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking to hold merge on my review (expected in <24h) 💯

@AngelOnFira AngelOnFira mentioned this pull request May 2, 2024
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a separate PR into this branch with many changes, that should be merged 👍🏻 #1501

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional items to look at

content/news/050/index.md Show resolved Hide resolved
content/news/050/index.md Outdated Show resolved Hide resolved
content/news/050/index.md Outdated Show resolved Hide resolved
content/news/050/index.md Outdated Show resolved Hide resolved
content/news/050/index.md Outdated Show resolved Hide resolved
AngelOnFira and others added 2 commits May 2, 2024 08:16
Co-authored-by: Forest Anderson <forestkzanderson@gmail.com>
@janhohenheim
Copy link
Collaborator Author

janhohenheim commented May 2, 2024

@Vrixyz I know you've distanced yourself in the past from phrases like "Jan and Thierry have led the newsletter revival", which is why I read the announcement the way I did originally. Could you check the wording in the announcement after @AngelOnFira's changes?

@Vrixyz
Copy link
Collaborator

Vrixyz commented May 2, 2024

@janhohenheim I feel like you deserve more credits in the wording but I'm fine with it 👍

@janhohenheim
Copy link
Collaborator Author

@janhohenheim I feel like you deserve more credits in the wording but I'm fine with it 👍

Then I'll leave it to @AngelOnFira on how to phrase it. I don't want to toot my own horn too much, haha.

@AngelOnFira
Copy link
Member

I know you've distanced yourself in the past from phrases like "Jan and Thierry have led the newsletter revival"

In rewording that paragraph, one item I tried to emphasize is that there still is a team behind the newsletter, it's not just a single person. I'm a bit adverse to giving off the impression that a single person is running everything without support, while also stating that the previous issue hiatus was a result of maintainer burnout 😅 if needed, I can try rewording the sentence in a different way.

In regards of credit, I think you both have done quite a lot in getting things rolling, so I'm happy with both names mentioned 👍🏻

@AngelOnFira AngelOnFira mentioned this pull request May 2, 2024
@janhohenheim
Copy link
Collaborator Author

janhohenheim commented May 2, 2024

@AngelOnFira

In rewording that paragraph, one item I tried to emphasize is that there still is a team behind the newsletter, it's not just a single person. I'm a bit adverse to giving off the impression that a single person is running everything without support, while also stating that the previous issue hiatus was a result of maintainer burnout 😅 if needed, I can try rewording the sentence in a different way.

Your reasoning makes sense to me, thanks for the explanation :) Let's leave it like this.

@janhohenheim
Copy link
Collaborator Author

janhohenheim commented May 2, 2024

re: community feedback, is that part of what's coming in from the survey, or was it discussed somewhere else?

From discussions on Discord. I don't like calling out specific names in public issues without their consent, but some very active community members wrote this, which makes me believe their opinion is representative of the community. Of course, if the survey tells us something different, I'll change my stance accordingly

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Everything looks good to me 🦀

@janhohenheim janhohenheim merged commit 6d4116e into source May 3, 2024
1 check passed
@janhohenheim janhohenheim deleted the release-50 branch June 30, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newsletter 50: April 2024
4 participants