Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N14: add Mun #292

Merged
merged 2 commits into from
Oct 5, 2020
Merged

N14: add Mun #292

merged 2 commits into from
Oct 5, 2020

Conversation

Wodann
Copy link
Contributor

@Wodann Wodann commented Oct 3, 2020

Completes the Mun section of #278

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ozkriff: Given that Mun posts updates just about every month, might it be a good idea to move the logo into static and reuse it between posts, like we do for Amethyst?

@ozkriff ozkriff mentioned this pull request Oct 4, 2020
49 tasks
@ozkriff ozkriff changed the title Newsletter 14: add Mun N14: add Mun Oct 4, 2020
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ozkriff ozkriff merged commit 8d33621 into rust-gamedev:source Oct 5, 2020
@ozkriff
Copy link
Member

ozkriff commented Oct 5, 2020

Given that Mun posts updates just about every month, might it be a good idea to move the logo into static and reuse it between posts, like we do for Amethyst?

@17cupsofcoffee well, we're not that much consistent about that logo :)

$ find content static -name amethyst-logo.png
content/posts/newsletter-013/amethyst-logo.png
content/posts/newsletter-009/amethyst-logo.png
content/posts/newsletter-004/amethyst-logo.png
content/posts/newsletter-008/amethyst-logo.png
content/posts/newsletter-010/amethyst-logo.png
content/posts/newsletter-006/amethyst-logo.png
static/amethyst-logo.png
$ g grep amethyst-logo.png         
content/posts/newsletter-001/index.md:![amethyst logo](/amethyst-logo.png)
content/posts/newsletter-002/index.md:![amethyst logo](/amethyst-logo.png)
content/posts/newsletter-003/index.md:![amethyst logo](/amethyst-logo.png)
content/posts/newsletter-004/index.md:![Amethyst logo](amethyst-logo.png)
content/posts/newsletter-006/index.md:[![Amethyst logo](amethyst-logo.png)][Amethyst]
content/posts/newsletter-008/index.md:[![Amethyst logo](amethyst-logo.png)][amethyst]
content/posts/newsletter-009/index.md:[![Amethyst logo](amethyst-logo.png)][amethyst]
content/posts/newsletter-010/index.md:[![Amethyst logo](amethyst-logo.png)][amethyst]
content/posts/newsletter-013/index.md:![logo](amethyst-logo.png)

and I'm still not sure how I feel about using static for reusing images - i don't like that it breaks normal markdown previews. Maybe we should try creating a special directory inside content and use relative paths there? something like

![amethyst logo](../../shared/amethyst-logo.png)

Relative paths up aren't that cool too, but it seems like a lesser evil to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants