Skip to content

Conversation

sotrh
Copy link
Contributor

@sotrh sotrh commented Dec 1, 2020

I didn't really have an image I wanted to use as all the changes have been mostly code based.

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good 👍 Just needs breaking onto multiple lines to satisfy the CI linter (max length is 80 chars)

@sotrh
Copy link
Contributor Author

sotrh commented Dec 1, 2020

I'll get that fixed. For future reference, is there a way to run the CI locally?

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

For future reference, is there a way to run the CI locally?

The CI job runs markdownlint. The easiest way to run it locally is to install an editor plugin - there's some links in the contributor's guide. I believe your editor should then pick up the config file.

@ozkriff ozkriff mentioned this pull request Dec 4, 2020
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (made a few small fmt tweaks for consistency wit the rest of the newsletter)

@ozkriff ozkriff merged commit 246758b into rust-gamedev:source Dec 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Dec 4, 2020

Merged, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants