Simplifying matching routes and constructing responses

[sv3ndk]

Hi,

I'm reading your book, I really like it!

I'm a rust beginner. While coding along at home and digging into what means what, I stumbled upon some possible code tweakings for chapter 3, which I'm sending below in case they might interrest you.

• matching on Method enums instead of string

• Similarly, using StatusCode enum instead of parsing integers, which makes the code more readable and avoids one call to .unwrap()

• Maybe it's just my personnal preference, I find the if let ... = matching syntax for Option more readable

• Other opinionated change: I let the generate_api_response() take full ownership of the Body instead of passing it as reference, since it's normally meant to be called last in the code flow, it avoids clone()ing the response to the POST method right after creating it, and it's inline with how the Response::builder() is structured.

One last aspect that was puzzling me was that sometimes the code is returning the output of generate_api_response(() directly, whereas sometimes it's unrapping it with ? then immediately re-bundling it into another Ok. Maybe there's some error we want to let bubble up in some cases that I don't understand, so I didn't dare to touch that part 😄

I hope you find some of this useful, let me know your thoughts!

[lmammino]

Hello, @sv3ndk!

Thank you so so much for not just buying a copy of the book but also for taking the time to submit a PR. This is super valuable for us and really motivating! ❤️

We'll do a proper review next week and try to get this merged in some form (plus adjust the code examples in the book to reflect the changes). At a first glance I like some of the suggestions, but I think there's some more fine tuning we can do. 😉

Thanks once more and have a great Sunday! 🌞

[lmammino]

Hello, @sv3ndk.

Sorry, this took us a little bit longer than anticipated.
I really liked the idea of using the status constants and applied that everywhere.

Your PR also made me realise that it might make more sense to have more util functions for all the different kinds of responses:

• A JSON response for a generic Serializable struct
• A response with an empty payload (to pass a specific error status code back to the user)
• A response for redirects

So I refactored the utils library and used this idea in the lambda code.

I'll propagate these changes in the code for all the other chapters and get this merged.

Thanks once again for your contribution! 🤝

[sv3ndk]

Hi,

Thanks for the very kind and detailed feed-back. Those updates look great!