-
Notifications
You must be signed in to change notification settings - Fork 313
Add tracing crate #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add tracing crate #736
Conversation
Local failures:
This seems to be from a version of log4rs which is really old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it. I wonder why ci doesn't find the new crate.
I think it's some random skeptic bug, but I'm not 100% sure. Perhaps if you consider #737 as a reasonable approach, I can skip to that with this PR instead? |
Sure, I'm up for a refactor. |
Cool - I'll wait to see your feedback on #737 and then take the same approach here as there. |
Fixes #706
🎉 Hi and welcome! Please read the text below and remove it - Thank you! 🎉
No worries if anything in these lists is unclear. Just submit the PR and ask away! 👍
Things to check before submitting a PR
cargo xtask test all
(These are failing in an unrelated way on the master branch)
https://docs.rs/tar/*/tar/struct.Entry.html
Things to do after submitting PR